Re: Minor bug and suggested fix - 1.2 and 1.3.5

[Mark A. Taff]

<font size=2 color="#993366"
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>Be happy to.� It would be a
great little project to `get my feet wet` as a new developer [albeit an minor
developer <font size=2
color="#993366" face=Wingdings><span style='font-size:10.0pt;mso-bidi-font-size:
12.0pt;font-family:Wingdings;mso-ascii-font-family:Arial;mso-hansi-font-family:
Arial;mso-char-type:symbol;mso-symbol-font-family:Wingdings'><span
style='mso-char-type:symbol;mso-symbol-font-family:Wingdings'>J<span
class=EmailStyle18><span
style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'> ]

<font size=2 color="#993366"
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color="#993366"
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>Regards,

<font size=2 color="#993366"
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color="#993366"
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>Mark

<font size=2 color="#993366"
face=Arial><span style='font-size:10.0pt;mso-bidi-font-size:12.0pt;font-family:
Arial'>�

<font size=2 color=black
face=Tahoma>-----Original
Message-----
From: Dave Page
[mailto:[EMAIL PROTECTED]]
Sent: Thursday, February 14, 2002
8:27 AM
To: 'Mark A. Taff';
pgadmin-hackers
Subject: RE: [pgadmin-hackers]
Minor bug and suggested fix - 1.2 and 1.3.5

<span
style='font-size:12.0pt'>�

<span
style='font-size:10.0pt;font-family:Arial;color:blue'>Sounds good. Care to give
it a go?<span style='color:black;mso-color-alt:
windowtext'>

<font size=3 color=black
face="Times New Roman">�<font
color=black>

<span
style='font-size:10.0pt;font-family:Arial;color:blue'>Regards, Dave.<font
color=black>



<p class=MsoNormal style='mso-margin-top-alt:auto;margin-bottom:12.0pt;
margin-left:39.75pt;border:none;mso-border-left-alt:solid blue 1.5pt;
padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><font size=2 color=black
face=Tahoma>-----Original
Message-----
From: Mark A. Taff
[mailto:[EMAIL PROTECTED]] 
Sent: 14 February 2002 16:15
To: Dave Page; pgadmin-hackers
Subject: RE: [pgadmin-hackers]
Minor bug and suggested fix - 1.2 and 1.3.5<span
style='color:black;mso-color-alt:windowtext'>

<p class=MsoNormal style='margin-left:39.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle17><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>We could just rewrite
EndMsg to accept an optional parameter (Optional ByVal szMsg As String) where
szMsg is "Done with errors - ".�
This could be set in LogError, then we test for the passed value and
modify the status bar message as required.

<p class=MsoNormal style='margin-left:39.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle17><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�

<p class=MsoNormal style='margin-left:39.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle17><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>Mark Taff

<p class=MsoNormal style='margin-left:39.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle17><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�





<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><font size=2
color=black face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma;
color:black'>-----Original Message-----
From: Dave Page
[mailto:[EMAIL PROTECTED]]
Sent: Thursday, February 14, 2002
8:05 AM
To: 'Mark A. Taff';
pgadmin-hackers
Subject: RE: [pgadmin-hackers]
Minor bug and suggested fix - 1.2 and 1.3.5<span
style='color:black;mso-color-alt:windowtext'>

<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><font size=3
color=black face="Times New Roman">�<font
color=black>

<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><font size=3
color=black face="Times New Roman">�<font
color=black>





<p class=MsoNormal style='mso-margin-top-alt:auto;margin-bottom:12.0pt;
margin-left:79.5pt;border:none;mso-border-left-alt:solid blue 1.5pt;padding:
0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
style='font-size:10.0pt;font-family:Tahoma;color:black'>-----Original
Message-----
From: Mark A. Taff
[mailto:[EMAIL PROTECTED]] 
Sent: 14 February 2002 15:48
To: pgadmin-hackers
Subject: [pgadmin-hackers] Minor
bug and suggested fix - 1.2 and 1.3.5<span
style='color:black;mso-color-alt:windowtext'>

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>All,

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'><span style='mso-tab-count:
1'>��������� I've found a
minor bug in 1.2 and 1.3.5.� When
an uncorrected error occurs and LogError is called after StartMsg has been
called, EndMsg is not always called, and so the cursor does not always return
to a normal cursor.� Rather than
trying to check and correct for this throughout the code, I've just done it
once in the LogError sub.� I've
pasted patched code based on 1.3.5 for your consideration below.

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>Regards,

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>Mark Taff

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>*** Begin patch for
pgAdmin2.basMisc.LogError v1.3.5 ***

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>Public Sub LogError(lError
As Long, szError As String, szRoutine As String)

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>'No logging here, if
anythings going wrong then we want the real error

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'><span style="mso-spacerun:
yes">� frmMain.svr.LogEvent "Error in " & szRoutine
& ": " & lError & " - " & szError, etErrors

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'><span style="mso-spacerun:
yes">� MsgBox "An error has occured in " & szRoutine
& ":" & vbCrLf & vbCrLf & "Number: " &
lError & vbCrLf & "Description: " & szError,
vbExclamation, App.Title & " Error"

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'><span style="mso-spacerun:
yes">� 

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'><span style="mso-spacerun:
yes">� 'If we get here, EndMsg may not fire, so give the user a
normal cursor...

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'><span style="mso-spacerun:
yes">� Screen.MousePointer = vbDefault

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'><span style="mso-spacerun:
yes">� 

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>End Sub

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>�

<p class=MsoNormal style='margin-left:79.5pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial'>*** End patch ***<span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial;color:blue'>�<font
color=black>





<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><font size=3
color=black face="Times New Roman">�<font
color=black>

<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial;color:blue'>It might be an
idea to set the status message�sensibly as well�- perhaps take a look
at EndMsg and see what else it does. I *think* the only other thing is display
the timings....<span style='color:black;
mso-color-alt:windowtext'>

<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><font size=3
color=black face="Times New Roman">�<font
color=black>

<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><font size=3
color=black face="Times New Roman">�<font
color=black>

<p class=MsoNormal style='margin-left:75.75pt;border:none;mso-border-left-alt:
solid blue 1.5pt;padding:0in;mso-padding-alt:0in 0in 0in 4.0pt'><span
class=EmailStyle16><span style='font-size:
10.0pt;mso-bidi-font-size:12.0pt;font-family:Arial;color:blue'>Regards,
Dave.�