Re: Minor bug and suggested fix - 1.2 and 1.3.5

Dave Page Thu, 14 Feb 2002 11:22:39 -0500 (EST)(envelope-from [email protected])

Sounds 
good. Care to give it a go?
<FONT face=Arial color=#0000ff 
size=2>�
<FONT face=Arial color=#0000ff 
size=2>Regards, Dave.
<BLOCKQUOTE dir=ltr 
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; 
MARGIN-RIGHT: 0px">
  
  <FONT 
  face=Tahoma size=2>-----Original Message-----From: Mark A. Taff 
  [mailto:[EMAIL PROTECTED]] Sent: 14 February 2002 
  16:15To: Dave Page; pgadmin-hackersSubject: RE: 
  [pgadmin-hackers] Minor bug and suggested fix - 1.2 and 
  1.3.5
  
  <FONT face=Arial color=navy 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">We 
  could just rewrite EndMsg to accept an optional parameter (Optional ByVal 
  szMsg As String) where szMsg is "Done with errors - ".<SPAN 
  style="mso-spacerun: yes">� This could be set in LogError, then we 
  test for the passed value and modify the status bar message as 
  required.
  <FONT face=Arial color=navy 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Arial color=navy 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Mark 
  Taff
  <FONT face=Arial color=navy 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Tahoma color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; COLOR: black; FONT-FAMILY: Tahoma">-----Original 
  Message-----From: Dave Page 
  [mailto:[EMAIL PROTECTED]]<SPAN 
  style="FONT-WEIGHT: bold">Sent: Thursday, February 14, 2002 8:05 
  AMTo: 'Mark A. Taff'; 
  pgadmin-hackersSubject: RE: 
  [pgadmin-hackers] Minor bug and suggested fix - 1.2 and 
1.3.5
  <FONT face="Times New Roman" 
  size=3><SPAN 
  style="FONT-SIZE: 12pt">�
  <FONT face="Times New Roman" 
  color=black size=3><SPAN 
  style="FONT-SIZE: 12pt; COLOR: black">�<FONT 
  color=black><SPAN 
  style="COLOR: black; mso-color-alt: windowtext">
  <DIV 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 4pt; PADDING-BOTTOM: 0in; BORDER-LEFT: blue 1.5pt solid; PADDING-TOP: 
0in; BORDER-BOTTOM: medium none">
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; MARGIN-BOTTOM: 12pt; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; 
BORDER-LEFT: medium none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; 
mso-margin-top-alt: auto; mso-border-left-alt: solid blue 1.5pt; mso-padding-alt: 0in 
0in 0in 4.0pt"><FONT 
  face=Tahoma color=black size=2><SPAN 
  style="FONT-SIZE: 10pt; COLOR: black; FONT-FAMILY: Tahoma">-----Original 
  Message-----From: Mark A. 
  Taff [mailto:[EMAIL PROTECTED]] <SPAN 
  style="FONT-WEIGHT: bold">Sent: 14 February 2002 15:48<SPAN 
  style="FONT-WEIGHT: bold">To: pgadmin-hackers<SPAN 
  style="FONT-WEIGHT: bold">Subject: [pgadmin-hackers] Minor bug and 
  suggested fix - 1.2 and 1.3.5<SPAN 
  style="COLOR: black; mso-color-alt: windowtext">
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">All,
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-tab-count: 1">���������� 
  I've found a minor bug in 1.2 and 1.3.5.<SPAN 
  style="mso-spacerun: yes">� When an uncorrected error occurs and 
  LogError is called after StartMsg has been called, EndMsg is not always 
  called, and so the cursor does not always return to a normal cursor.<SPAN 
  style="mso-spacerun: yes">� Rather than trying to check and 
  correct for this throughout the code, I've just done it once in the LogError 
  sub.� I've pasted patched code 
  based on 1.3.5 for your consideration 
  below.
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Regards,
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Mark 
  Taff
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">*** 
  Begin patch for pgAdmin2.basMisc.LogError v1.3.5 
  ***
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Public 
  Sub LogError(lError As Long, szError As String, szRoutine As 
  String)
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">'No 
  logging here, if anythings going wrong then we want the real 
  error
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� frmMain.svr.LogEvent "Error in " & 
  szRoutine & ": " & lError & " - " & szError, 
  etErrors
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� MsgBox "An error has occured in " 
  & szRoutine & ":" & vbCrLf & vbCrLf & "Number: " & 
  lError & vbCrLf & "Description: " & szError, vbExclamation, 
  App.Title & " Error"
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� 
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� 'If we get here, EndMsg may not fire, 
  so give the user a normal cursor...
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� Screen.MousePointer = 
  vbDefault
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� 
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">End 
  Sub
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <P class=MsoNormal 
  style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; 
PADDING-LEFT: 0in; PADDING-BOTTOM: 0in; MARGIN-LEFT: 39.75pt; BORDER-LEFT: medium 
none; PADDING-TOP: 0in; BORDER-BOTTOM: medium none; mso-border-left-alt: solid blue 
1.5pt; mso-padding-alt: 0in 0in 0in 4.0pt"><SPAN 
  class=EmailStyle16><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">*** 
  End patch ***<FONT face=Arial 
  color=blue size=2><SPAN 
  style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial; mso-bidi-font-size: 
12.0pt">�<FONT 
  color=black><SPAN 
  style="COLOR: black; mso-color-alt: windowtext">
  <FONT face="Times New Roman" 
  color=black size=3><SPAN 
  style="FONT-SIZE: 12pt; COLOR: black">�<FONT 
  color=black><SPAN 
  style="COLOR: black; mso-color-alt: windowtext">
  <FONT 
  face=Arial color=blue size=2><SPAN 
  style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial; mso-bidi-font-size: 
12.0pt">It 
  might be an idea to set the status message�sensibly as well�-
  perhaps take a look at EndMsg and see what else it does. I *think* the only 
  other thing is display the timings....<FONT 
  color=black><SPAN 
  style="COLOR: black; mso-color-alt: windowtext">
  <FONT face="Times New Roman" 
  color=black size=3><SPAN 
  style="FONT-SIZE: 12pt; COLOR: black">�<FONT 
  color=black><SPAN 
  style="COLOR: black; mso-color-alt: windowtext">
  <FONT face="Times New Roman" 
  color=black size=3><SPAN 
  style="FONT-SIZE: 12pt; COLOR: black">�<FONT 
  color=black><SPAN 
  style="COLOR: black; mso-color-alt: windowtext">
  <FONT 
  face=Arial color=blue size=2><SPAN 
  style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial; mso-bidi-font-size: 
12.0pt">Regards, 
  Dave.�
Re: Minor bug and suggested fix - 1.2 and 1.3.5

Reply via email to
