Re: Minor bug and suggested fix - 1.2 and 1.3.5

[Dave Page]

�
<BLOCKQUOTE dir=ltr 
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; 
MARGIN-RIGHT: 0px">
  
  <FONT 
  face=Tahoma size=2>-----Original Message-----From: Mark A. Taff 
  [mailto:[EMAIL PROTECTED]] Sent: 14 February 2002 
  15:48To: pgadmin-hackersSubject: [pgadmin-hackers] Minor 
  bug and suggested fix - 1.2 and 1.3.5
  
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">All,
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-tab-count: 1">����������� 
  I've found a minor bug in 1.2 and 1.3.5. <SPAN 
  style="mso-spacerun: yes">�When an uncorrected error occurs and 
  LogError is called after StartMsg has been called, EndMsg is not always 
  called, and so the cursor does not always return to a normal cursor.<SPAN 
  style="mso-spacerun: yes">� Rather than trying to check and 
  correct for this throughout the code, I've just done it once in the LogError 
  sub.� I've pasted patched code 
  based on 1.3.5 for your consideration 
  below.
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Regards,
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Mark 
  Taff
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">*** 
  Begin patch for pgAdmin2.basMisc.LogError v1.3.5 
  ***
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Public 
  Sub LogError(lError As Long, szError As String, szRoutine As 
  String)
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">'No 
  logging here, if anythings going wrong then we want the real 
  error
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� frmMain.svr.LogEvent "Error in " & 
  szRoutine & ": " & lError & " - " & szError, 
  etErrors
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� MsgBox "An error has occured in " 
  & szRoutine & ":" & vbCrLf & vbCrLf & "Number: " & 
  lError & vbCrLf & "Description: " & szError, vbExclamation, 
  App.Title & " Error"
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� 
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� 'If we get here, EndMsg may not fire, 
  so give the user a normal cursor...
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� Screen.MousePointer = 
  vbDefault
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-spacerun: yes">� 
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">End 
  Sub
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">*** 
  End patch ***<SPAN 
  class=507135915-14022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><FONT 
color=#0000ff><SPAN 
class=507135915-14022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><FONT 
color=#0000ff>It might be an idea to set the 
status message�sensibly as well�- perhaps take a look at EndMsg and 
see what else it does. I *think* the only other thing is display the 
timings....
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><FONT 
color=#0000ff><SPAN 
class=507135915-14022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><FONT 
color=#0000ff><SPAN 
class=507135915-14022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><FONT 
color=#0000ff>Regards, 
Dave.�