Gregory Stark escribió: > "Tom Lane" <[EMAIL PROTECTED]> writes: > > > This falls in the category of "destabilizing the code for purely > > cosmetic reasons", and would be a foolish change to make at RC1 time. > > I suppose. Expect to have more bug reports like this one then though. > > > We could change the text of the ERROR message reasonably easily, > > but changing the basic transaction abort method is right out. > > I fear having a message saying "ERROR This is not an error" is going to get us > laughed at.
I don't advocate changing that ERROR to anything else. The message wording, as Tom says, can easily be changed -- I think this patch should be enough. Feel free to propose better wording. -- Alvaro Herrera http://www.PlanetPostgreSQL.org/ Voy a acabar con todos los humanos / con los humanos yo acabaré voy a acabar con todos / con todos los humanos acabaré (Bender)
Index: src/backend/tcop/postgres.c =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/backend/tcop/postgres.c,v retrieving revision 1.538 diff -c -p -c -4 -r1.538 postgres.c *** src/backend/tcop/postgres.c 15 Nov 2007 21:14:38 -0000 1.538 --- src/backend/tcop/postgres.c 4 Dec 2007 17:02:35 -0000 *************** ProcessInterrupts(void) *** 2577,2584 **** --- 2577,2588 ---- if (cancel_from_timeout) ereport(ERROR, (errcode(ERRCODE_QUERY_CANCELED), errmsg("canceling statement due to statement timeout"))); + else if (IsAutoVacuumWorkerProcess()) + ereport(ERROR, + (errcode(ERRCODE_QUERY_CANCELED), + errmsg("autovacuum task cancelled"))); else ereport(ERROR, (errcode(ERRCODE_QUERY_CANCELED), errmsg("canceling statement due to user request")));
---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq