Dear Horiguchi-san, Fujii-san Thank you for discussing!
> Isn't it enough to perform this assertion check only once > at the top of parse_pgfdw_appname()? Fixed. > If possible, I'd like to see this change as a separate patch > and commt it first because this is the description for > the existing parameter postgres_fdw.application_name. I attached a small doc patch for this. > "pgfdw_application_name is set to application_name of a pgfdw > connection after placeholder conversion, thus the resulting string is > subject to the same restrictions to application_names.". Maybe > followed by "If session user name or database name contains non-ascii > characters, they are replaced by question marks "?"". This part was also added. Thanks! > So our current consensus is to remove the padding part > from postgres_fdw.application_name. Yeah I removed. Attached patches are the latest version. Best Regards, Hayato Kuroda FUJITSU LIMITED
v22_0002_allow_escapes.patch
Description: v22_0002_allow_escapes.patch
v22_0001_update_descriptions.patch
Description: v22_0001_update_descriptions.patch