On Wed, Jan 12, 2022 at 3:00 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > I just looked at 0002 because of Justin Pryzby's comment in the column > filtering thread, and realized that the pgoutput row filtering has a > very strange API, which receives both heap tuples and slots; and we seem > to convert to and from slots in seemingly unprincipled ways. I don't > think this is going to fly. I think it's OK for the initial entry into > pgoutput to be HeapTuple (but only because that's what > ReorderBufferTupleBuf has), but it should be converted a slot right when > it enters pgoutput, and then used as a slot throughout. >
One another thing that we can improve about 0002 is to unify the APIs for row filtering for update and insert/delete. I find having separate APIs a bit awkward. -- With Regards, Amit Kapila.
