On Thu, Jan 13, 2022 at 12:19 PM Peter Smith <smithpb2...@gmail.com> wrote: > > 7. src/backend/replication/pgoutput/pgoutput.c - pgoutput_row_filter > > + /* > + * For the following occasions where there is only one tuple, we can > + * evaluates the row filter for the not null tuple and return. > + * > + * For INSERT: we only have new tuple. > + * > + * For UPDATE: if no old tuple, it means none of the replica identity > + * columns changed and this would reduce to a simple update. we only need > + * to evaluate the row filter for new tuple. > + * > + * FOR DELETE: we only have old tuple. > + */ > > There are several things not quite right with that comment: > a. I thought now it should refer to "slots" instead of "tuples" >
I feel tuple still makes sense as it makes the comments/code easy to understand. -- With Regards, Amit Kapila.