On 2/16/22 16:01, Andres Freund wrote: > Hi, > > On 2022-02-16 15:46:28 -0500, Andrew Dunstan wrote: >> I suggest that we apply this patch: > +1 > >> and if nothing breaks in a few days I will set about a more thorough >> removal of perl2host() and adjusting everywhere it's called, and we can >> forget that the whole sorry mess ever happened :-) > I think we would need an error check against using an msys perl when targeting > native windows, otherwise this'll be too hard to debug.
So something like this in Utils.pm: die "Msys targeted perl is unsupported for running TAP tests" if $Config{osname}eq 'msys'; > > And we probably should set that environment variable that might fix in-tree > tests? Or reject in-tree builds? I think that's an orthogonal issue, but yes we should probably set it. Have you tested to make sure it does what we want? I certainly don't want to reject in-tree builds. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com