On 2/17/22 13:10, Andres Freund wrote: > On 2022-02-17 13:08:01 -0500, Andrew Dunstan wrote: >>>> perhaps something like: >>>> >>>> >>>> my $msystem = $ENV{MSYSTEM} || 'undef'; >>>> >>>> die "incompatible perl" if $Config{osname} eq 'msys' && $msystem ne >>>> 'MSYS'; >>> Why tests MSYSTEM instead of $host_os? >> Is that available in check_modules.pl? AFAICT it's an unexported shell >> variable. > No, but it could just be passed to it?
Sure, that could be done, but what's the issue? Msys2 normally defines MSYSTEM for you - see /etc/msystem which is sourced by /etc/profile. > Or the test just implemented in > configure, as I suggested. > No, because we don't know which perl will be invoked by $PROVE. That's why we set up check_modules.pl in the first place. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com