On 2/17/22 12:12, Andres Freund wrote: > Hi, > > On 2022-02-17 09:20:56 -0500, Andrew Dunstan wrote: >> I don't think we have or have ever had a buildfarm animal targeting >> msys. In general I think of msys as a build environment to create native >> binaries. But if we want to support targeting msys we should have an >> animal doing that. > It's pretty much cygwin. Wouldn't hurt to have a dedicated animal though, I > agree. We do have a dedicated path for it in configure.ac: > > case $host_os in > ... > cygwin*|msys*) template=cygwin ;; > > > >>> I think this means we should do the msys test in configure, inside >>> >>> if test "$enable_tap_tests" = yes; then >>> >>> and verify that $host_os != msys. >> config/check_modules.pl is probably the right place for the test, as it >> will be running with the perl we should be testing, and is only called >> if we configure with TAP tests enabled. > Makes sense. > > >> perhaps something like: >> >> >> my $msystem = $ENV{MSYSTEM} || 'undef'; >> >> die "incompatible perl" if $Config{osname} eq 'msys' && $msystem ne >> 'MSYS'; > Why tests MSYSTEM instead of $host_os?
Is that available in check_modules.pl? AFAICT it's an unexported shell variable. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com