On 2/19/22 13:04, Andrew Dunstan wrote: > On 2/16/22 15:46, Andrew Dunstan wrote: >> Largely following a recipe from Andres, I have migrated buildfarm >> animals fairywren and jacana to a setup that shouldn't need (and in fact >> won't be able to use) PostgreSQL::Test:Utils::perl2host(). AFAICT these >> two are the only buildfarm animals that run TAP tests under msys. > [...] > > >> I suggest that we apply this patch: >> >> > [...] >> and if nothing breaks in a few days I will set about a more thorough >> removal of perl2host() and adjusting everywhere it's called, and we can >> forget that the whole sorry mess ever happened :-) I know a number of >> people who will be overjoyed. >> >> > > OK, nothing broke, so here are two more invasive patches. The first > removes perl2host completely and adjusts all the places that use it. > The second removes almost all the remaining msys special processing in > TAP tests. > > > I have tested these and they appear to work fine. > >
It turns out we can also remove the skip code in src/bin/pg_dump/t/010_dump_connstr.pl cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com