Hi, On Mon, Feb 21, 2022 at 2:36 PM Michael Paquier <mich...@paquier.xyz> wrote: > > Hi all, > (Author and committer added in CC.) > > While reviewing the code of a bunch of SRF functions in the core code, > I have noticed that the two functions mentioned in $subject are marked > as proretset but both functions don't return a set of tuples, just one > record for the object given in input. It is also worth noting that > prorows is set to 1.
Thanks for pointing it out. Agreed. > > This looks like a copy-pasto error that has spread around. The error > on pg_stat_get_subscription_worker is recent as of 8d74fc9, and the > one on pg_stat_get_replication_slot has been introduced in 3fa17d3, > meaning that REL_14_STABLE got it wrong for the second part. > > I am aware about the discussions on the parent view for the first > case and its design issues, but it does not change the fact that we'd > better address the second case on HEAD IMO. > > Thoughts? Agreed. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
