Hi, On 2023-02-01 12:15:29 -0800, Nathan Bossart wrote: > Here's a new patch set in which I've attempted to address this feedback and > Michael's feedback.
Looks better! > @@ -25,12 +34,14 @@ extern PGDLLIMPORT char *XLogArchiveLibrary; > * For more information about the purpose of each callback, refer to the > * archive modules documentation. > */ > -typedef bool (*ArchiveCheckConfiguredCB) (void); > -typedef bool (*ArchiveFileCB) (const char *file, const char *path); > -typedef void (*ArchiveShutdownCB) (void); > +typedef void (*ArchiveStartupCB) (ArchiveModuleState *state); > +typedef bool (*ArchiveCheckConfiguredCB) (ArchiveModuleState *state); > +typedef bool (*ArchiveFileCB) (const char *file, const char *path, > ArchiveModuleState *state); > +typedef void (*ArchiveShutdownCB) (ArchiveModuleState *state); Personally I'd always pass ArchiveModuleState *state as the first arg, but it's not important. Greetings, Andres Freund
