On Wed, Feb 01, 2023 at 01:23:26PM -0800, Nathan Bossart wrote: > Yeah, that's nicer. cfbot is complaining about a missing #include, so I > need to send a new revision anyway.
Okay, the changes done here look straight-forward seen from here. I
got one small-ish comment.
+basic_archive_startup(ArchiveModuleState *state)
+{
+ BasicArchiveData *data = palloc0(sizeof(BasicArchiveData));
Perhaps this should use MemoryContextAlloc() rather than a plain
palloc(). This should not matter based on the position where the
startup callback is called, still that may be a pattern worth
encouraging.
--
Michael
signature.asc
Description: PGP signature
