Hi On Mon, 8 Jul 2024 at 22:44, Andres Freund <and...@anarazel.de> wrote:
> Hi, > > On 2024-07-08 16:56:10 -0400, Andrew Dunstan wrote: > > On 2024-07-08 Mo 4:16 PM, Andres Freund wrote: > > > I'm actually mildly surprised that the tests don't fail when *not* > using > > > autocrlf, because afaict test_json_parser_incremental.c doesn't set > stdout to > > > binary and thus we presumably end up with \r\n in the output? Except > that that > > > can't be true, because the test does pass on repos without autocrlf... > > > > > > > > > That approach does seem to mildly conflict with Tom and your > preference for > > > fixing this by disallowing core.autocrlf? If we do so, the test never > ought to > > > see a crlf? > > > > > > > IDK. I normally use core.autocrlf=false core.eol=lf on Windows. The > editors > > I use are reasonably well behaved ;-) > > :) > > > > What I suggest (see attached) is we run the diff command with > > --strip-trailing-cr on Windows. Then we just won't care if the expected > file > > and/or the output file has CRs. > > I was wondering about that too, but I wasn't sure we can rely on that flag > being supported... > I have 4 different diff.exe's on my ~6 week old build VM (not counting shims), all of which seem to support --strip-trailing-cr. Those builds came with: - git - VC++ - diffutils (installed by chocolatey) - vcpkg I think it's reasonable to assume it'll be supported. > > > > Not sure what the issue is with pg_bsd_indent, though. > Yeah - that's odd, as that test always passes for me, with or without autocrlf. The other failures I see are the following, which I'm just starting to dig into: 26/298 postgresql:recovery / recovery/019_replslot_limit ERROR 43.05s exit status 2 44/298 postgresql:recovery / recovery/027_stream_regress ERROR 383.08s exit status 1 50/298 postgresql:recovery / recovery/035_standby_logical_decoding ERROR 138.06s exit status 25 68/298 postgresql:recovery / recovery/040_standby_failover_slots_sync ERROR 132.87s exit status 25 170/298 postgresql:pg_dump / pg_dump/002_pg_dump ERROR 93.45s exit status 2 233/298 postgresql:bloom / bloom/001_wal ERROR 54.47s exit status 2 236/298 postgresql:subscription / subscription/001_rep_changes ERROR 46.46s exit status 2 246/298 postgresql:subscription / subscription/010_truncate ERROR 47.69s exit status 2 253/298 postgresql:subscription / subscription/013_partition ERROR 125.63s exit status 25 255/298 postgresql:subscription / subscription/022_twophase_cascade ERROR 58.13s exit status 2 257/298 postgresql:subscription / subscription/015_stream ERROR 128.32s exit status 2 262/298 postgresql:subscription / subscription/028_row_filter ERROR 43.14s exit status 2 263/298 postgresql:subscription / subscription/027_nosuperuser ERROR 102.02s exit status 2 269/298 postgresql:subscription / subscription/031_column_list ERROR 123.16s exit status 2 271/298 postgresql:subscription / subscription/032_subscribe_use_index ERROR 139.33s exit status 2 -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com