Dear Shlok, > I agree that .pg_reload_conf() is not required. I have removed it in > the latest version of patches.
Thanks for updating the patch! After considering bit more, I started to feel the test should be under the test/modules/unsafe_tests. Adding test requires that wal_level >= replica and max_logical_replication_slots >= 1, but `make installcheck` might allow to run such an environment. unsafe_tests can ensure that test would be run only while `make check`. Also, ALTER SYSTEM requires to be superuser and the test has already used the privileges. Best regards, Hayato Kuroda FUJITSU LIMITED
