Dear Shlok,
Thanks for updating the patch! Few comments.
1.
You must separate patch for master and PG18, because
ReplicationSlotValidateNameInternal()
does not accept `bool allow_reserved_name` in the version.
2.
Also, test for PG18 should not have the case which rejects the reserved name.
3.
```
-- Parallel worker does not throw error during startup.
SET min_parallel_table_scan_size TO 0;
SET parallel_setup_cost TO 0;
SET parallel_tuple_cost TO 0;
```
According to contrib/pg_stat_statements/sql/parallel.sql,
max_parallel_workers_per_gather
should be also set. There is a possiblity that `make installcheck` is used and
it has max_parallel_workers_per_gather=0.
4.
```
foreach_ptr(char, name, *elemlist)
```
You can add a comment atop here like:
Iterate the list to validate each slot name.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
