Thanks everyone for reviewing my proposal. Please let me know if you have something to discuss here.
2025年11月19日(水) 0:31 Nathan Bossart <[email protected]>: > On Wed, Nov 19, 2025 at 12:20:34AM +0900, Sugamoto Shinya wrote: > > On Tue, Nov 18, 2025 at 1:07 PM Fujii Masao <[email protected]> > wrote: > >> Is there a guideline on when we should use the ClosestMatch machinery > >> instead of explicitly listing valid values? From the discussion in [1], > >> it seems appropriate when there are many possible values. > >> But should we generally replace all hints that list valid values > >> with ClosestMatch, or only in specific cases? > > I think it makes sense to reserve it for cases with several possible > values. > > > Personally I agree with this. Since there are only the four options in > > this case, it wouldn't be difficult for users to find a correct encoding > > from the hint message even without showing a possible encoding. Also, > > using ClosestMatch here to show a possible encoding would encourage > > similar additions later which might bloat our error handling. Keeping > > code simple by notifying the user of the valid encodings should be > > sufficient for this part. > > WFM > > -- > nathan >
