On 19.11.25 14:47, Fujii Masao wrote:
On Wed, Nov 19, 2025 at 10:04 PM Daniel Gustafsson <[email protected]> wrote:
On 19 Nov 2025, at 14:01, Fujii Masao <[email protected]> wrote:
You changed the HINT message to use format arguments,
but I still think it's better to embed the values directly (e.g.,
Valid encodings are "base64", "base64url", "escape", and "hex".)
for consistency with similar HINT messages. If this message is
used in many places a parameterized style would help translators,
but that benefit doesn't apply here.
Attached is an updated version of the patch. I switched
the HINT message to the embedded form and updated the commit message.
Barring any objections, I'm thinking to commit this.
My intepreration was that this version was already objected to by Peter
upthread in [email protected]. The point
there being that punctuation in lists is subject to translation.
Yes, so I was thinking a message like "Valid encodings are %s" isn't acceptable
since the punctuation included in the %s value is not translated. In contrast,
a message like "Valid encodings are \"base64\", …" is fine because all
punctuation
is part of the translatable string itself, I thought.
My point was a different one. It is generally preferable to separate
translatable and untranslated things. So, as an example from elsewhere,
instead of
errhint("Use ALTER DOMAIN instead.");
it would be better to use
errhint("Use % instead.", "ALTER DOMAIN");
Similarly, here I would prefer something along the lines of
errhint("Valid values are \"%s\", \"%s\", and \"%s\".", "foo", "bar",
"baz");
So like it was done in patch v3 looks good to me.
