On Mon, Mar 16, 2026 at 10:37 AM Chao Li <[email protected]> wrote:
> V2 overall looks good to me.
>
> A small comment is about the variable name logged_lock_waits that sounds like 
> “count of waits”, I would suggest “lock_wait_logged”. But I see that the name 
> follows the naming convention of the existing variable 
> logged_recovery_conflict, so maybe just rename to logged_lock_wait (remove 
> the “s”).
>

TBH I'm not sure whether renaming the variable that way is a good idea,
but I don't have a strong opinion about this. So I renamed it to
logged_lock_wait (i.e., removed the trailing "s").

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao


Reply via email to