On Mon, Apr 6, 2026 at 10:00 PM Hüseyin Demir <[email protected]> wrote: > Appreciated for the patch. I reviewed it quickly. > > In the test description it says that `still waiting logged exactly once > despite pg_reload_conf() wakeups")` but the test sends via > pg_log_backend_memory_contexts(). It would make sense to update it. > > ``` > - 1, "still waiting logged exactly once despite pg_reload_conf() wakeups"); > + 1, "still waiting logged exactly once despite wakeups from > pg_log_backend_memory_contexts()"); > ``` > > Secondly, before finishing the test it tries to check that no log_lock_waits > messages are emitted. But the comment has the opposite meaning. > > ``` > - 'check that log_lock_waits message is emitted when the lock is acquired > after waiting' > + 'check that no log_lock_waits message is emitted when the lock is > acquired after waiting' > ``` > > I'm not sure they need to change but these are the only topics I wanted to > add. Otherwise, lgtm and thanks. > > I attached the v3 to convey my ideas. You can use it or update the existing > if you think the suggestions are reasonable.
Thanks for the review and for updating the patch! Your changes look good to me. I also added a comment explaining why the test wakes the backend, and then pushed the patch. Thanks again! Regards, -- Fujii Masao
