Hi,
> Thanks for the patch! > > Commit 557a9f1e3e6 recently added test for lock stats, which also causes > lock wait situations. So it seems better to extend that test to cover > log_lock_waits rather than adding a new TAP test file. > > I've prepared a patch to do this. Patch attached. Thought? > > Regards, > Appreciated for the patch. I reviewed it quickly. In the test description it says that `still waiting logged exactly once despite pg_reload_conf() wakeups")` but the test sends via pg_log_backend_memory_contexts(). It would make sense to update it. ``` - 1, "still waiting logged exactly once despite pg_reload_conf() wakeups"); + 1, "still waiting logged exactly once despite wakeups from pg_log_backend_memory_contexts()"); ``` Secondly, before finishing the test it tries to check that no log_lock_waits messages are emitted. But the comment has the opposite meaning. ``` - 'check that log_lock_waits message is emitted when the lock is acquired after waiting' + 'check that no log_lock_waits message is emitted when the lock is acquired after waiting' ``` I'm not sure they need to change but these are the only topics I wanted to add. Otherwise, lgtm and thanks. I attached the v3 to convey my ideas. You can use it or update the existing if you think the suggestions are reasonable. Regards.
v3-0001-Add-TAP-tests-for-log_lock_waits.patch
Description: Binary data
