On Thu, Apr 9, 2026 at 9:05 PM Peter Smith <[email protected]> wrote: > On Thu, Apr 9, 2026 at 1:34 PM Chao Li <[email protected]> wrote: > > > ... > > > > I am not sure if your scope includes contrib/, if yes, I am sure you will > > find some occurrences there. > > > > Updated one more message found in contrib. > > PSA v2. >
+1 to the general idea here, although at the risk of looking at patches before the morning coffee has settled in, ISTM you might have missed some entries? And/or this patch isn't against HEAD? For example, you seem to be catching the line here https://github.com/postgres/postgres/blame/009ea1b08d7b8843435bd0f1137fa3df09aac79f/src/test/regress/expected/partition_split.out#L60, but not the one on line 52, maybe because it looks like a comment (but istm we should clean these all up. no?) Also FWIW, it might seem a little weird not to clean up the grammar issues too, but I think this is the right move, to update these changes cleanly/separately and do those changes as a separate patch, I can imagine that some of those will require more futzing, for example > "To split DEFAULT partition one of the new partition must be DEFAULT." > missing word? -- "To split the DEFAULT partition" > should be plural? -- "one of the new partitions" > I guess there is a balance wrt terseness, and maybe needs a comma: "To split DEFAULT partition, one new partition must be DEFAULT." "To split the DEFAULT partition, one of the new partitions must be DEFAULT." "To split a DEFAULT partition, one of the new partitions must be created as DEFAULT." Robert Treat https://xzilla.net
