Hi, On Tue, Aug 18, 2026 at 10:41:51AM +0200, Daniel Gustafsson wrote: > > On 18 Aug 2026, at 06:55, Bertrand Drouvot <[email protected]> > > wrote: > > Added a new test here to make it's still reported per the initdb state. > > > Also worth checking in 004_offline.pl after, > > > > " > > # Enable checksums offline using pg_checksums > > $node->stop; > > $node->checksum_enable_offline; > > $node->start; > > " > > > > that pg_control_init() still reports the initial disabled state? That would > > also > > verify for the pg_checksums case. > > Added.
Thanks for the updated version! > I also added another test for pg_control_checkpoint in 004_offline to test the > state before and after a CHECKPOINT from offline checksum enabling. Yeah, makes sense to me. I don't have more comments, LGTM. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
