Re: Fix WITHOUT OVERLAPS multirange with location replication

[Zhijie Hou]

Hi,

On Tue, Oct 13, 2026 at 7:21 PM Amit Kapila <amit.kapil...@gmail.com> wrote:
>
> On Tue, Oct 13, 2026 at 5:37 AM Paul A Jungwirth
> <p...@illuminatedcomputing.com> wrote:
> >
> > This v4 looks good to me. Thank you for helping with this! Maybe one
> > minor change:
> >
> > src/test/subscription/t/035_conflicts.pl
> > +# Publisher table holding the row that will be updated.
> > +$node_B->safe_psql(
> > +   'postgres', "
> > +   CREATE TABLE tab_mr (id int4multirange, valid_at daterange, v int);
> > +   ALTER TABLE tab_mr REPLICA IDENTITY FULL;
> > +   INSERT INTO tab_mr VALUES ('{[1,5)}', '[2000-01-01,2010-01-01)', 1);
> > +   ALTER PUBLICATION tap_pub_B ADD TABLE tab_mr;
> > +");
> >
> > If we say PRIMARY KEY (id, valid_at WITHOUT OVERLAPS) then we don't
> > need REPLICA IDENTITY FULL.
> >
>
> Yeah, but keeping RI FULL also doesn't harm; rather it tests something
> extra which is that it can extract required values from the full
> tuple. So, I am okay either way. I have modified the comments at
> multiple places in the patch as I find there is a lot of redundancy in
> the comments. See attached top-up patch. BTW, we need a separate patch
> for v18 as well.

Thanks for the diff. I have merged and prepared the patches for
back branches as well.

Best Regards,
Zhijie Hou

v5_PG19-0001-Fix-logical-replication-with-multirange-WITH.patch
Description: Binary data

v5-0001-Fix-logical-replication-with-multirange-WITHOUT-O.patch
Description: Binary data

v5_PG18-0001-Fix-logical-replication-with-multirange-WITH.patch
Description: Binary data