On Mon, Oct 19, 2026 at 7:49 PM shveta malik <[email protected]> wrote: > > On Mon, Oct 19, 2026 at 1:42 PM Chao Li <[email protected]> wrote: > > ... > > I think this is an improvement by making the meaning of ONLY and * clearer. > > > > I just have nit comment: > > ``` > > + the publication, so they are never explicitly added to the > > publication. > > ``` > > > > “so they are never explicitly added to the publication” might be read as a > > child partition cannot be added explicitly, however I verified the > > following is valid: > > ``` > > CREATE TABLE p (id integer) PARTITION BY RANGE (id); > > CREATE TABLE p1 PARTITION OF p FOR VALUES FROM (0) TO (100); > > CREATE PUBLICATION pub FOR TABLE p, p1; > > ``` > > > > So, how about: > > ``` > > the publication, so they do not need to be explicitly added to the > > publication. > > ``` > > +1. I had the same thought while reviewing. Although the goal here is > just to clarify the point about ONLY, we can also make the subsequent > sentence less ambiguous in the same patch. >
Hi Chao and Shveta. Thanks for your review comments. I agree with you. PSA patch v2, which also fixes the misleading "never" wording in the original sentence. ====== Kind Regards, Peter Smith. Fujitsu Australia
v2-0001-DOCS-Remove-ambiguous-wording-about-ONLY-for-part.patch
Description: Binary data
