Hi all

> Thanks for your review comments. I agree with you.
> 
> PSA patch v2, which also fixes the misleading "never" wording in the
> original sentence.

Thank you for creating another thread per my suggestion.
The patch V2 looks good to me.

It's completely optional but I noticed that ALTER PUBLICATION doc [1]
also mentions ONLY and '*' though ALTER PUBLICATION doc does not mention
partitioned table at all. How about adding the similar note to ALTER
doc? I know the main purpose of this patch is to remove ambiguous
sentence from CREATE PUBLICATION doc. But it could be worthwhile to
clarify how postgres behaves also in ALTER doc.

I tested myself and ALTER also ignores ONLY and * for partitioned table
as well.

[1] https://www.postgresql.org/docs/devel/sql-alterpublication.html
---
Name of an existing table. If ONLY is specified before the table_name,
only that table is affected. If ONLY is not specified, the table and all
its descendant tables (if any) are affected. Optionally, * can be
specified after the table_name to explicitly indicate that descendant
tables are included.
---

Regards,
Takeshi Ideriha


Reply via email to