Hi,

On Sun, Nov 15, 2026 at 10:35:57PM -0800, Masahiko Sawada wrote:
> 
> I'm concerned that not only changes to this function but also changes
> to its callers could break these assumptions, and nothing near those
> places would tell us about them.

Yeah, I agree with this concern. Looking at 788ec96d591, I think 
remote_slot_precedes
was redundant with slotsync_skip_reason, but found_consistent_snapshot was not:
slotsync_skip_reason reports why synchronization was skipped, while 
found_consistent_snapshot
tells the caller whether the slot is safe to persist.

v2 is correct with the current temporary slot caller, which persists the slot
immediately. But relying on this call sequence seems fragile. So I'd vote for
restoring found_consistent_snapshot.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com


Reply via email to