On Sat, Nov 14, 2026 at 12:11 PM Bertrand Drouvot
<[email protected]> wrote:
>
> On Sat, Nov 14, 2026 at 09:04:57AM +0530, Amit Kapila wrote:
> > On Fri, Nov 13, 2026 at 7:29 PM Bertrand Drouvot
> > <[email protected]> wrote:
> >
> > Right the reason can remain as SS_SKIP_WAL_OR_ROWS_REMOVED. Even in
> > the first cycle, the reason could be either SS_SKIP_WAL_NOT_FLUSHED or
> > SS_SKIP_WAL_OR_ROWS_REMOVED and in that case also the caller
>
> Oh right, I missed SS_SKIP_WAL_NOT_FLUSHED.
>
> > update_and_persist_local_synced_slot() won't persist the slot. So, I
> > don't see a problem with retaining the previous reason when we didn't
> > perform anything in a particular sync cycle.
>
> Right, but once the WAL has been flushed or the remote slot has caught up,
> retaining SS_SKIP_WAL_NOT_FLUSHED or SS_SKIP_WAL_OR_ROWS_REMOVED would make
> slotsync_skip_reason report a misleading reason: the slot remains temporary
> because it still has no consistent snapshot.
>
Fair enough, so we can update the skip_reason as the latest patch from
Hou-San does but we should add a DEBUG1 or LOG level message like we
do in other cases in the same function. How about something on the
following line:
ereport(DEBUG1,
errmsg("could not synchronize
replication slot \"%s\"",
remote_slot->name),
errdetail("The standby has not yet
reached a consistent "
"point when decoding
WAL from LSN %X/%08X, and "
"the remote slot has
not advanced since the "
"last attempt.",
LSN_FORMAT_ARGS(slot->data.restart_lsn)));
--
With Regards,
Amit Kapila.