On Wed, Nov 18, 2026 at 9:48 AM Ajin Cherian <[email protected]> wrote: > > On Wed, Nov 18, 2026 at 2:39 PM shveta malik <[email protected]> wrote: > > > > Good point Ajin. I did not think of it earlier, but on analysing it > > now, I think there is a way out without the race: since > > disable_on_error can be changed on a disabled sub, the user can > > temporarily set 'disable_on_error=false' on disabled sub, then ENABLE > > the sub, then REFRESH PUBLICATION, and then set disable_on_error back > > to true. I tested this with the patch, and it works. > > > > Yes, that works as a workaround. > > > > > As you said, this applies to all tablesync errors caused by > > publisher-side changes, so I think documenting it would be better done > > separately,e.g. as a note in the disable_on_error description? > > Thoughts? But if others feel that we can combine it in this patch, I > > am okay to do that. > > Yes, a note in the disable_on_error description sounds good.
Done. Attached v3-0002. No change in 0001. > On Wed, Nov 18, 2026 at 2:40 PM shveta malik <[email protected]> wrote: > > > > I missed mentioning that alternatively, the table can be published > > again on the publisher before re-enabling (if necessary). > > > > I don't think users would want to do that if they removed the table > from the publication deliberately. It also isn't an option for an > UNLOGGED table like in Shlok's example, which can't be published at > all, or for a table that has been dropped on the publisher. Okay, I have still added a generic line about this in the doc without mentioning any specific resolution in this context. thanks Shveta
v3-0002-Doc-Explain-how-to-recover-a-subscription-disable.patch
Description: Binary data
v3-0001-Do-not-copy-the-whole-table-in-tablesync-when-no-.patch
Description: Binary data
