Hi Shveta. Patch v3-0001 is unchanged, so it still LGTM.
Below are some comments for v3-0002 (docs). ====== src/sgml/ref/create_subscription.sgml 1. + <note> + <para> + If the error persists, the subscription is disabled again as soon + as it is re-enabled. For example, if initial table synchronization + fails because the table was dropped on the publisher or removed + from the publication, + <link linkend="sql-altersubscription-params-refresh-publication"><command>ALTER SUBSCRIPTION ... REFRESH PUBLICATION</command></link> + is needed to remove it from the subscription. However, this + command is not allowed while the subscription is disabled. ... IMO the "For example" doesn't seem to illustrate the preceding sentence. The sentence says the subscription keeps getting disabled, but the example jumps straight to a cause (table dropped/unpublished) and then to the fix (REFRESH PUBLICATION). It never says that this is a case where the error recurs, so the subscription keeps disabling itself. There're a couple of other minor nits -- e.g. "as soon as it is re-enabled" is not quite accurate. The subscription is only disabled again after the worker hits the error again, not at the moment it is enabled. My LLM came up with some reworded text split into example and workaround paragraphs, which I think is better. SUGGESTION <note> <para> If the underlying cause is not resolved, the subscription is disabled again shortly after it is re-enabled. For example, if initial table synchronization fails because the table was dropped on the publisher or removed from the publication, the same error recurs each time the synchronization is retried. </para> <para> In that case, <link linkend="sql-altersubscription-params-refresh-publication"><command>ALTER SUBSCRIPTION ... REFRESH PUBLICATION</command></link> is needed to remove the table from the subscription, but it cannot be run while the subscription is disabled. To work around this, either fix the cause on the publisher before re-enabling the subscription, or temporarily set <literal>disable_on_error</literal> to <literal>false</literal>, re-enable the subscription using <link linkend="sql-altersubscription-params-enable"><command>ALTER SUBSCRIPTION ... ENABLE</command></link>, run <command>ALTER SUBSCRIPTION ... REFRESH PUBLICATION</command>, and then set <literal>disable_on_error</literal> back to <literal>true</literal>. </para> </note> ~~~ 2. But is this the best place for describing the disable_on_error workaround? A user who hits the REFRESH PUBLICATION restriction is probably going to be looking at the ALTER SUBSCRIPTION docs, so maybe the workaround details belong there? ====== Kind Regards, Peter Smith. Fujitsu Australia
