On Thu, 19 Nov 2026 at 14:52, shveta malik <[email protected]> wrote:
>
> > 2. The REFRESH PUBLICATION block can be removed:
> > +# REFRESH PUBLICATION removes the tables from the subscription.
> > +$node_subscriber->safe_psql('postgres',
> > +       "ALTER SUBSCRIPTION tap_sub_2 REFRESH PUBLICATION");
> > +
> > +$result = $node_subscriber->safe_psql('postgres',
> > +       "SELECT count(*) FROM pg_subscription_rel WHERE srrelid IN
> > ('tab_4'::regclass, 'tab_5'::regclass)"
> > +);
> > +is($result, qq(0),
> > +       'check that REFRESH PUBLICATION removes the tables from the
> > subscription');
> >
> > 025_rep_changes_for_schema.pl already checks that tables are removed
> > from pg_subscription_rel after REFRESH
> > PUBLICATION.
>
> I gave it some thought; I think we should keep it. Both the errhint
> and the doc patch suggest REFRESH PUBLICATION as the way to recover,
> so it seems good to test that it works in exactly the state this fix
> leaves behind, i.e. tables whose initial sync failed and are still in
> DATASYNC. 025 only removes tables that are already READY. What do you
> say?

I'm fine with it.

This issue is applicable to back branches also, can you share back
branch patches too.

Regards,
Vignesh


Reply via email to