On Wed, 18 Nov 2026 at 15:56, vignesh C <[email protected]> wrote:
>
> Thanks for the comments and changes, I have merged the changes with
> slight changes in the 002 patch, there are no changes in 001 and 003
> patch, it is the same as the v94 version patch. The attached v95
> version patch has the changes for the same.
Few comments:
1. catalogs.sgml is missing the new pg_subscription columns:
subconflictlogrelid and subconflictlogdest
2. Should we mention "for the elements of the local_conflicts array"
instead of "for the conflict log table"
+ * build_local_conflicts_tupledesc
+ *
+ * Build and bless a tuple descriptor for the conflict log table based on the
+ * predefined LocalConflictSchema.
+ */
+static TupleDesc
+build_local_conflicts_tupledesc(void)
3. Should the relation be quoted here:
+ appendStringInfo(&err_detail,
+ _("Conflict details
are logged to the conflict log table: %s.%s."),
+
get_namespace_name(RelationGetNamespace(conflictlogrel)),
+
RelationGetRelationName(conflictlogrel));
4. Stray blank line at executor.h:
+/* Avoid including access/transam.h here */
+typedef struct FullTransactionId FullTransactionId;
+
5. typo
5.a) Should "instead index's" be "instead of index's":
+ /*
+ * See BuildIndexValueDescription() for why we
used rd_opcintype
+ * instead index's tupleDesc.
+ */
5.b)Should "have already been exited" be "have already exited"
+ * Ensure
workers have already been exited to
+ * avoid
getting prepared transactions while we
Regards,
Vignesh