On Thu, Nov 19, 2026 at 7:51 PM Zhijie Hou <[email protected]> wrote: > > Hi, > > On Thu, Nov19, 2026 at 06:06 PM vignesh C wrote: > > On Wed, 18 Nov 2026 at 15:56, vignesh C <[email protected]> wrote: > > > > > > Thanks for the comments and changes, I have merged the changes with > > > slight changes in the 002 patch, there are no changes in 001 and 003 > > > patch, it is the same as the v94 version patch. The attached v95 > > > version patch has the changes for the same. > > > > Few comments: > > 1. catalogs.sgml is missing the new pg_subscription columns: > > subconflictlogrelid and subconflictlogdest > > I think this is existing issue on HEAD, so we can have a separate patch > to fix it.
I think we should address this in 0003, where we have the other describe-subscription changes. I vaguely recall discussing this with the team long back, and the idea was to group these changes together. Thoughts? > Other comments look good to me and have been addressed in the new > version patch. > > Here is the V96 version which: > > 1. Addressed above comments. > > 2. Updated the local_conflicts column doc to drop "existing", as it also > records deleted tuple metadata for update_deleted conflicts (per > Kuroda-San's off-list suggestion). > > 3. Clarified the replica_identity doc to note that recorded key text > matches a column SELECT for most columns (index opclass input types such > as oid_ops on regclass can format values differently, such as recording > an OID, though casting back to the column's type still resolves to the > target row and does not affect conflict inspection or resolution) (per > Shveta's off-list suggestion). > > 4. Added a code comment in insert_conflict_log_tuple() explaining why > heap_insert() is used directly instead of table_tuple_insert(). > > > Only 0001 patch is changed. > > -- > Best Regards, > Zhijie Hou
