On Sun, Nov 18, 2018 at 9:43 PM Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2018/11/17 9:06, Michael Paquier wrote: > > On Fri, Nov 16, 2018 at 09:38:40AM -0500, Robert Haas wrote: > >> OK, but it seems to me that your version of my patch rearranges the > >> code more than necessary. > >> > >> How about the attached? > > > > What you are proposing here looks good to me. Thanks! > > Me too, now that I see the patch closely. The errors I'd seen in the > regression tests were due to uninitialized oids variable which is fixed in > the later patches, not due to "confused memory context switching" as I'd > put it [1] and made that the reason for additional changes.
OK. Rebased again, and committed (although I forgot to include a link to this discussion - sorry about that). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
