Hi Alexandra, As Michael said it will be considered for the next commitfest. But from a quick glance, a suggestion. Instead of passing NULL parsestate from ATExecAttachPartition, pass make_parsestate(NULL). parse_errorposition() takes care of NULL parse state input, but it might be safer this way. Better if we could cook up a parse state with the query text available in AlterTableUtilityContext available in ATExecCmd().
On Thu, Apr 9, 2020 at 6:36 AM Alexandra Wang <lew...@pivotal.io> wrote: > > Forgot to run make installcheck. Here's the new version of the patch that > updated the test answer file. > -- Best Wishes, Ashutosh Bapat