On Thu, Apr 9, 2020 at 10:51 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > Hi Alexandra, > As Michael said it will be considered for the next commitfest. But > from a quick glance, a suggestion. > Instead of passing NULL parsestate from ATExecAttachPartition, pass > make_parsestate(NULL). parse_errorposition() takes care of NULL parse > state input, but it might be safer this way. Better if we could cook > up a parse state with the query text available in > AlterTableUtilityContext available in ATExecCmd().
+1. Maybe pass the *context* down to ATExecAttachPartition() from ATExecCmd() rather than a ParseState. -- Amit Langote EnterpriseDB: http://www.enterprisedb.com
