On Tuesday, September 14, 2021 10:41 PM vignesh C <vignes...@gmail.com> wrote:
> On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com 
> <houzj.f...@fujitsu.com> wrote:
> >
> >
> > Attach new version patches which addressed the comment.
> 
> Thanks for fixing this issue. The bug gets fixed by the patch, I did not find 
> any
> issues in my testing.
> I just had one minor comment:
> 
> We could clean the table at the end by calling DROP TABLE testpub_parted2:
> +-- still fail, because parent's publication replicates updates UPDATE
> +testpub_parted2 SET a = 2;
> +ERROR:  cannot update table "testpub_parted2" because it does not
> have a replica identity and publishes updates
> +HINT:  To enable updating the table, set REPLICA IDENTITY using ALTER
> TABLE.
> +ALTER PUBLICATION testpub_forparted DROP TABLE testpub_parted;
> +-- works again, because update is no longer replicated UPDATE
> +testpub_parted2 SET a = 2;

Thanks for the comment.
Attach new version patches which clean the table at the end.

Best regards,
Hou zj

Attachment: v3-0001-Made-the-existing-relation-cache-invalidation-an.patch
Description: v3-0001-Made-the-existing-relation-cache-invalidation-an.patch

Attachment: v3-0002-Invalidate-all-partitions.patch
Description: v3-0002-Invalidate-all-partitions.patch

Reply via email to