Tom Lane wrote:
Andrew Dunstan <and...@dunslane.net> writes:
I have reviewed this and made a small tweak in the docco. I'm just about ready to commit this, but I'm still slightly worried that passing NULL to denote all columns in this piece of grammar:

            | FORCE QUOTE '*'
                {
                    $$ = makeDefElem("force_quote", NULL);
                }

might be less than robust - it just feels slightly hacky, so I'd appreciate others' thoughts.

I agree, that's ugly.  Why don't you use an A_Star node?

                        

OK, Done and committed. Nice little addition.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to