On Fri, 2009-09-25 at 10:01 -0400, Emmanuel Cecchet wrote: > Robert, > > Here is the new version of the patch that applies to CVS HEAD as of this > morning.
I just started looking at this now. It seems to fail "make check", diffs attached. I haven't looked into the cause of the failure yet. Regards, Jeff Davis
*** /home/jdavis/wd/git/postgresql/src/test/regress/expected/copy_errorlogging.out 2009-10-04 10:24:15.000000000 -0700 --- /home/jdavis/wd/git/postgresql/src/test/regress/results/copy_errorlogging.out 2009-10-04 10:24:32.000000000 -0700 *************** *** 46,58 **** -- both \n and \r\n present COPY foo FROM '/home/jdavis/wd/git/postgresql/src/test/regress/data/foo_malformed_terminator.data'; - ERROR: literal carriage return found in data - HINT: Use "\r" to represent carriage return. - CONTEXT: COPY foo, line 2: "" SELECT count(*) from foo; count ------- ! 0 (1 row) -- create error logging table --- 46,55 ---- -- both \n and \r\n present COPY foo FROM '/home/jdavis/wd/git/postgresql/src/test/regress/data/foo_malformed_terminator.data'; SELECT count(*) from foo; count ------- ! 5 (1 row) -- create error logging table *************** *** 75,81 **** SELECT count(*) from foo; count ------- ! 4 (1 row) DELETE FROM foo; --- 72,78 ---- SELECT count(*) from foo; count ------- ! 9 (1 row) DELETE FROM foo; *************** *** 101,113 **** DELETE FROM foo; -- error logging skipping tuples: both \n and \r\n present COPY foo FROM '/home/jdavis/wd/git/postgresql/src/test/regress/data/foo_malformed_terminator.data' (ERROR_LOGGING, ERROR_LOGGING_SKIP_BAD_ROWS); - ERROR: literal carriage return found in data - HINT: Use "\r" to represent carriage return. - CONTEXT: COPY foo, line 2: "" SELECT count(*) from foo; count ------- ! 0 (1 row) DELETE FROM foo; --- 98,107 ---- DELETE FROM foo; -- error logging skipping tuples: both \n and \r\n present COPY foo FROM '/home/jdavis/wd/git/postgresql/src/test/regress/data/foo_malformed_terminator.data' (ERROR_LOGGING, ERROR_LOGGING_SKIP_BAD_ROWS); SELECT count(*) from foo; count ------- ! 5 (1 row) DELETE FROM foo; ======================================================================
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers