>>>>> "Hitoshi" == Hitoshi Harada <umi.tan...@gmail.com> writes:
Hitoshi> Attached is updated version. I added AggGetMemoryContext() Hitoshi> in executor/nodeAgg.h (though I'm not sure where to go...) Hitoshi> and its second argument "iswindowagg" is output parameter to Hitoshi> know whether the call context is Agg or WindowAgg. Your Hitoshi> proposal of APIs to know whether the function is called as Hitoshi> Aggregate or not is also a candidate to be, but it seems out Hitoshi> of this patch scope, so it doesn't touch anything. I don't really like the extra argument; aggregate functions should almost never have to care about whether they're being called as window functions rather than aggregate functions. And if it does care, I don't see why this is the appropriate function for it. At the very least the function should accept NULL for the "iswindowagg" pointer to avoid useless variables in the caller. So for this and the regression test problem mentioned in the other mail, I'm setting this back to "waiting on author". -- Andrew. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
