>>>>> "Hitoshi" == Hitoshi Harada <umi.tan...@gmail.com> writes:
>> So for this and the regression test problem mentioned in the other >> mail, I'm setting this back to "waiting on author". Hitoshi> In my humble opinion, view regression test is not necessary Hitoshi> in both my patch and yours. At least window test has not Hitoshi> been testing views so far since it was introduced. Am I Hitoshi> missing? If you don't want to include views in the regression test, then take them out; I will object to that, but I'll leave it up to the committer to decide whether it is appropriate, provided the other concerns are addressed. But what you have in the regression tests _now_ is, as far as I can tell, only working by chance; with "rules" and "window" being in the same parallel group, and window.sql creating a view, you have an obvious race condition, unless I'm missing something. I included view tests in my own patch for the very simple reason that I found actual bugs that way during development. -- Andrew (irc:RhodiumToad) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
