On Tue, Feb 2, 2010 at 20:46, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Feb 2, 2010 at 10:46 PM, Robert Haas <robertmh...@gmail.com> wrote: >> On Tue, Feb 2, 2010 at 10:42 PM, Alex Hunsaker <bada...@gmail.com> wrote: >>> On Sat, Jan 30, 2010 at 08:49, Tim Bunce <tim.bu...@pobox.com> wrote: >>>> This is an update the fourth of the patches to be split out from the >>>> former 'plperl feature patch 1'. >>>> >>>> Changes in this patch: >>>> >>>> - Adds plperl.on_trusted_init and plperl.on_untrusted_init GUCs >>>> on_trusted_init is PGC_USERSET, on_untrusted_init is PGC_SUSET >>> >>> Im not a fan of the names (I think everyone gets trusted vs untrusted >>> confused). May I humbly suggest: >>> plperl.on_init >>> plperlu.on_init >>> plperl.both_on_init <- this one is the one that throws the scheme off :(
>> With all due respect.... yuck. heh, well I feel as reviewer its my job to solicit feed back from the community. If I have to do it by suggesting gross names, so be it. > OK, third time is the charm. Sigh. The "yuck" was in reference > specifically to the proposed GUC names. Yeah the both is gross. How about: plperl.on_plperl_init plperl.on_plperlu_init plperl.on_init ? > I like the original ones better. I think they are OK. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
