On Wed, Apr 7, 2010 at 1:45 AM, Magnus Hagander <mag...@hagander.net> wrote:
> No, I don't mean that. I mean store it in one place, and copy/link it
> into where it's used. Look at for example how crypt.c and
> getaddrinfo.c are handled in libpq.

Thanks for the advice!

> Not sure how that will play with PGXS, though, but I'm not entirely
> sure we care if it can be built that way?

Probably Yes.

> If it does, there should be
> some way to get PGXS to execute that rule as well, I'm sure.

If we can copy/link the source file defining "new PQexec" when
we compile the dblink, DLL doesn't seem to be required. So I
stop creating new DLL for PGXS.

> Also note that per Tom's comments this is not a win32 only fix, so it
> shouldn't be called pgwin32_*().

Yep.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to