On Thu, Apr 15, 2010 at 4:17 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: >> Looking at the call-sites, there are bugs now - if PQexec() returns >> NULL, we don't deal with it. It also doesn't always free the result >> properly. I've added checks for that. > > I think you're just adding useless complexity there. PQresultStatus > defends itself just fine against a NULL input, and most other libpq > functions likewise.
Yeah, I realized that after posting it. I was still stuck in ancient times when at least some of those functions couldn't be called with NULL pointers, so I just put that in there by default :-) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
