On Thu, Jun 9, 2011 at 10:15 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Thu, Jun 9, 2011 at 10:07 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> We are relying on isupper() to not return true >>> when presented with a character fragment in a multibyte locale. > >> Based on Jeevan's original message, it seems like that's not always >> the case, at least on Windows. > > Hmm. Now that you mention it, I think the same has been said about OSX. > > If we need to work around brain-dead isupper() tests, maybe the best > thing is to implement two versions of the loop: > > if (encoding is single byte) > ... loop as it stands ... > else > ... loop without the "else if" part
That seems like a clear improvement. It's a long way from perfect, but still worthwhile. Would we back-patch that? Just do it in master? Wait for 9.2? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
