On Thu, Jun 9, 2011 at 11:17 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Thu, Jun 9, 2011 at 10:15 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> If we need to work around brain-dead isupper() tests, maybe the best >>> thing is to implement two versions of the loop: >>> if (encoding is single byte) > >> That seems like a clear improvement. It's a long way from perfect, >> but still worthwhile. > > Hmm ... while the above is easy enough to do in the backend, where we > can look at pg_database_encoding_max_length, we have also got instances > of this coding pattern in src/port/pgstrcasecmp.c. It's a lot less > obvious how to make the test in frontend environments. Thoughts anyone?
I'm not sure if this helps at all, but an awful lot of those tests are against hard-coded strings that are known to contain only ASCII characters. Is there some way we can optimize this for that case? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
