On Tue, May 14, 2013 at 5:27 AM, Peter Eisentraut <pete...@gmx.net> wrote: > On Tue, 2013-05-14 at 04:12 +0300, Marti Raudsepp wrote: >> It's caused by this common pattern in extension makefiles: >> DATA = $(wildcard sql/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql
> What is the point of this? Why have the wildcard and then the > non-wildcard term? Because the non-wildcard file is built by the same Makefile (it's copied from the sql/$(EXTENSION).sql file). If it wasn't there, a "make install" from a clean checkout would miss this file. all: sql/$(EXTENSION)--$(EXTVERSION).sql sql/$(EXTENSION)--$(EXTVERSION).sql: sql/$(EXTENSION).sql cp $< $@ > I think using wildcard is bad style and you should fix it. Perhaps, but fixing the extensions is not a solution at this point. A large number of extensions use this exact code (it comes from David Wheeler's template AFAIK). We might stand a chance in fixing the public extensions on PGXN, but this would presumably still break non-public extensions that people have written. For example: David Wheeler's pgTAP https://github.com/theory/pgTAP/blob/master/Makefile#L91 Jan Urbański's first_last_agg https://github.com/wulczer/first_last_agg/blob/master/Makefile Andrew Dunstan's json_build https://github.com/pgexperts/json_build/blob/master/Makefile Theo Schlossnagle's pg_amqp http://api.pgxn.org/src/pg_amqp/pg_amqp-0.3.0/Makefile OmniTI's pg_jobmon https://github.com/omniti-labs/pg_jobmon/blob/master/Makefile Regards, Marti -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers