Le mardi 14 mai 2013 10:17:13, Marti Raudsepp a écrit : > On Tue, May 14, 2013 at 5:27 AM, Peter Eisentraut <pete...@gmx.net> wrote: > > On Tue, 2013-05-14 at 04:12 +0300, Marti Raudsepp wrote: > >> It's caused by this common pattern in extension makefiles: > >> DATA = $(wildcard sql/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql > > > > What is the point of this? Why have the wildcard and then the > > non-wildcard term? > > Because the non-wildcard file is built by the same Makefile (it's > copied from the sql/$(EXTENSION).sql file). If it wasn't there, a > "make install" from a clean checkout would miss this file. > > all: sql/$(EXTENSION)--$(EXTVERSION).sql > > sql/$(EXTENSION)--$(EXTVERSION).sql: sql/$(EXTENSION).sql > cp $< $@ > > > I think using wildcard is bad style and you should fix it. > > Perhaps, but fixing the extensions is not a solution at this point. A > large number of extensions use this exact code (it comes from David > Wheeler's template AFAIK). We might stand a chance in fixing the > public extensions on PGXN, but this would presumably still break > non-public extensions that people have written.
My understanding is that the offending commit reveals possible bad written instruction in some Makefile. What's wrong ? -- Cédric Villemain +33 (0)6 20 30 22 52 http://2ndQuadrant.fr/ PostgreSQL: Support 24x7 - Développement, Expertise et Formation
signature.asc
Description: This is a digitally signed message part.
