On Sat, Sep 28, 2013 at 8:42 AM, Marko Tiikkaja <ma...@joh.to> wrote:
> On 2013-09-28 12:31, Ian Lawrence Barwick wrote:
>> The patch looks good to me now; does the status need to be changed to
>> "Ready for Committer"?
>
> Yes.
>
> Thanks for reviewing!

This looks like a nice clean patch.  My only concern is that it makes
"on" and "off" unreserved plpgsql keywords.  It looks like that will
make them unusable as unquoted identifiers in a few contexts in which
they can now be used.  Has there been any discussion about whether
that's OK?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to